fix(ts-sdk): export ClusterSortOption type#1171
Conversation
|
CI note after opening this focused #1169 fix:
|
PR Review: PASS (NOT VERIFIED)What This DoesAdds Blast RadiusTypeScript SDK public model exports only: Consumer VerificationBefore (base branch): // origin/main, sdks/typescript/pmxt/models.ts
export type MatchedClusterSort = 'volume' | 'confidence';A consumer import such as After (PR branch): export type ClusterSortOption = 'volume' | 'confidence';
export type MatchedClusterSort = ClusterSortOption;Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- public type export/backward-compatible alias fix. RiskI could not run the TypeScript package build or public-export Jest test in this review environment because generated SDK artifacts are absent, so this is verified by static source inspection rather than a compiled package import. |
Summary
ClusterSortOptionfrom the TypeScript SDK models to match the Python SDK's canonical cluster sort type.MatchedClusterSortas an alias ofClusterSortOptionfor existing callers.Fixes #1169
Test Plan
npm test --workspace=pmxtjs -- --runInBand tests/public-exports.test.tsfailed withModule '../index' has no exported member 'ClusterSortOption'.npx tsc --noEmit --skipLibCheck --moduleResolution node --target ES2020 --module commonjs sdks/typescript/pmxt/models.ts../generated/src/index.js). Attemptednpm run generate --workspace=pmxtjs, but this runner lacksjavafor openapi-generator.